linux-kernel - Re: [PATCH 3/3] trusted-keys: small cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201101182003.ACH57348.HOtFMVOLJQSOFF@I-love.SAKURA.ne.jp>
Date:	Tue, 18 Jan 2011 20:03:49 +0900
From:	Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
To:	zohar@...ux.vnet.ibm.com
Cc:	safford@...son.ibm.com, safford@...ibm.com, jj@...osbits.net,
	dhowells@...hat.com, jmorris@...ei.org, keyrings@...ux-nfs.org,
	linux-security-module@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] trusted-keys: small cleanup

Mimi Zohar wrote:
> > >       va_end(argp);
> > > -     ret = crypto_shash_final(&sdesc->shash, paramdigest);
> > > +     if (!ret)
> > > +             ret = crypto_shash_final(&sdesc->shash, paramdigest);
> > >       if (!ret)
> 
> Change the second '(!ret)' here, the crypto_shash_file() return code
> test, from '(!ret)' to '(ret < 0)', like the other crypto_shash_file()
> tests.

Did you mean changing from

	if (!ret)
		ret = crypto_shash_final(&sdesc->shash, paramdigest);

to

	if (ret < 0)
		ret = crypto_shash_final(&sdesc->shash, paramdigest);

(i.e. invert the condition)?

I'm confused. Would you make the patch by yourself?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/