linux-kernel - Re: linux-next: build failure after merge of the rr tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4D36B729.4040609@stericsson.com>
Date:	Wed, 19 Jan 2011 11:04:25 +0100
From:	Linus Walleij <linus.walleij@...ricsson.com>
To:	Stephen Rothwell <sfr@...b.auug.org.au>
Cc:	Rusty Russell <rusty@...tcorp.com.au>,
	"linux-next@...r.kernel.org" <linux-next@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: linux-next: build failure after merge of the rr tree

On 01/19/2011 05:42 AM, Stephen Rothwell wrote:
> Presumably caused by commit b64781e8e2b0f480affb170460cbfb3b11fa9e5d
> ("param: add null statement to compiled-in module params").  I wonder how
> many more build errors this change may provoke.  Please try to find them
> and fix them before adding this change, thanks.
>    

It can provoke if I'm not mistaken, one more error. So two in total.

grep -r -E '^MODULE_.*\(.*\) *[^;]* *$' .
Yields a lot of false positives (enhancements welcome) that sifts down
to these two:

./net/dsa/dsa.c:MODULE_AUTHOR("Lennert Buytenhek <buytenh@...tstofly.org>")
./drivers/net/arm/ks8695net.c:MODULE_AUTHOR("Simtec Electronics")

I'll send patches for these two, so Rusty can apply them on
top of his next branch and be done with it.

> I used the version of the rr tree from next-20110118 for today.
>    

Couldn't find any more violators in the next tree.

There shouldn't be many: any file that is built as modules with
allmod will result in compile error even without this patch, the two above
must already be broken with allmodconfig, presumably they are
used in archs that do not enable loadable modules, so they don't
see the problem.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/