linux-kernel - Re: [RFC][PATCH 0/2 v1.0]sched: updating /proc/schedstat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4D37098A.8010706@linux.vnet.ibm.com>
Date:	Wed, 19 Jan 2011 21:25:54 +0530
From:	Ciju Rajan K <ciju@...ux.vnet.ibm.com>
To:	Satoru Takeuchi <takeuchi_satoru@...fujitsu.com>
CC:	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	lkml <linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...e.hu>,
	Bharata B Rao <bharata@...ux.vnet.ibm.com>,
	Srivatsa Vaddagiri <vatsa@...ibm.com>,
	Ciju Rajan K <ciju@...ux.vnet.ibm.com>
Subject: Re: [RFC][PATCH 0/2 v1.0]sched: updating /proc/schedstat


>>
>> This patch set removes only those fields which are currently not in use.
>> If you observe the fields of /proc/schedstat the following fields are not
>> being updated.
> 
> Ah... I misunderstood the meaning of `unused' and complained based on too
> old kernel's source. Sorry.> 

> I confirmed that these fields are actually not treated by upstream kernel
> at all. So I think it's OK if any userland tools are updated synchronized
> with this change.

Thanks for verifying it.

 Does its benefit is more than its cost? In my
> understanding, its benefit is improving readability and reducing some memory
> footprint, and its cost is changing all userspace tools referring /proc/schedstat.

In my opinion we should go ahead with updating /proc/schedstat. 
As I mentioned earlier, we can have an updated script for 
http://eaglet.rain.com/rick/linux/schedstat/ 

> 
> # Unfortunately I don't know how much it costs.

The changes required in the userspace would be very small. 
Its just a matter of re-ordering the values. I also can't think
of much complicated scenario than this.

-Ciju
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/