linux-kernel - Re: [PATCH] Avoid a NULL pointer in btrfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1295452288-sup-8924@think>
Date:	Wed, 19 Jan 2011 10:52:16 -0500
From:	Chris Mason <chris.mason@...cle.com>
To:	Josef Bacik <josef@...hat.com>
Cc:	Liuwenyi <qingshenlwy@...il.com>, strongzgy <strongzgy@...il.com>,
	onlyflyer <onlyflyer@...il.com>,
	linux-btrfs <linux-btrfs@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	ak <ak@...ux.intel.com>, akpm <akpm@...ux-foundation.org>,
	miaox <miaox@...fujitsu.com>,
	Yang Ruirui <ruirui.r.yang@...to.com>,
	meego-kernel <meego-kernel@...go.com>
Subject: Re: [PATCH] Avoid a NULL pointer in btrfs

Excerpts from Josef Bacik's message of 2011-01-19 09:14:02 -0500:
> On Wed, Jan 19, 2011 at 10:08:13PM +0800, Liuwenyi wrote:
> > In Yang Ruirui's mail, the btrfs will create a oops. This is caused by a
> > null pointer in test_range_bit() while lock the spinlock.
> > 
> > So, It is necessary to add a pointer check into test_range_bit()
> > 
> 
> 
> NAK, the tree shouldn't be null coming into this function, something else is
> going wrong.  What oops is this?  Thanks,

What was your metadata blocksize for this oops?  This call should never
happen.

I think there is a larger problem, probably in the IO error handling
code since the trace had io errors beforehand.

-chris
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/