linux-kernel - [PATCH] pohmelfs/dir.c: Remove unneeded mutex_unlock() from pohmelfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <40908.91.79.118.36.1295471624.squirrel@mail.ispras.ru>
Date:	Thu, 20 Jan 2011 00:13:44 +0300 (MSK)
From:	"Alexey Khoroshilov" <khoroshilov@...ras.ru>
To:	"Evgeniy Polyakov" <zbr@...emap.net>
Cc:	"Greg Kroah-Hartman" <gregkh@...e.de>, "Tejun Heo" <tj@...nel.org>,
	"Ruslan Pisarev" <ruslan@...sarev.org.ua>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: [PATCH] pohmelfs/dir.c: Remove unneeded mutex_unlock() from 
     pohmelfs_rename()

I do not see any reason for the mutex_unlock(&inode->i_mutex); in
pohmelfs_rename().


Found by Linux Driver Verification project (linuxtesting.org).


Signed-off-by: Alexey Khoroshilov <khoroshilov@...ras.ru>
---
diff --git a/drivers/staging/pohmelfs/dir.c b/drivers/staging/pohmelfs/dir.c
index 059e9d2..9732a96 100644
--- a/drivers/staging/pohmelfs/dir.c
+++ b/drivers/staging/pohmelfs/dir.c
@@ -1082,7 +1082,6 @@ err_out_exit:

        clear_bit(NETFS_INODE_REMOTE_SYNCED, &pi->state);

-       mutex_unlock(&inode->i_mutex);
        return err;
 }

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/