linux-kernel - Re: [PATCH] pohmelfs/dir.c: Remove unneeded mutex_unlock() from pohmelfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110120105113.GA24827@ioremap.net>
Date:	Thu, 20 Jan 2011 13:51:13 +0300
From:	Evgeniy Polyakov <zbr@...emap.net>
To:	Alexey Khoroshilov <khoroshilov@...ras.ru>
Cc:	Greg Kroah-Hartman <gregkh@...e.de>, Tejun Heo <tj@...nel.org>,
	Ruslan Pisarev <ruslan@...sarev.org.ua>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pohmelfs/dir.c: Remove unneeded mutex_unlock() from
 pohmelfs_rename()

On Thu, Jan 20, 2011 at 12:13:44AM +0300, Alexey Khoroshilov (khoroshilov@...ras.ru) wrote:
> I do not see any reason for the mutex_unlock(&inode->i_mutex); in
> pohmelfs_rename().
> 
> 
> Found by Linux Driver Verification project (linuxtesting.org).

Yes, that's a bug, we already unlocked i_mutex in common path and should
not do that on error.

Thank you. Greg, please apply.

> Signed-off-by: Alexey Khoroshilov <khoroshilov@...ras.ru>

Acked-by: Evgeniy Polyakov <zbr@...emap.net>

-- 
	Evgeniy Polyakov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/