linux-kernel - Re: [PATCH] drm/i915: Dont kick-off hangcheck after a DRI interrupt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <0d30dc$kqbkiv@orsmga001.jf.intel.com>
Date:	Thu, 20 Jan 2011 11:00:25 +0000
From:	Chris Wilson <chris@...is-wilson.co.uk>
To:	Herbert Xu <herbert@...dor.apana.org.au>
Cc:	Jesse Barnes <jbarnes@...tuousgeek.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/i915: Dont kick-off hangcheck after a DRI interrupt

On Thu, 20 Jan 2011 21:10:10 +1100, Herbert Xu <herbert@...dor.apana.org.au> wrote:
> While the current kernel tree has indeed changed from 2.6.36,
> I don't think this is the spot corresponding to my crash.
> 
> My spot was in hangcheck_elapsed and as far as I can see it will
> crash in the current kernel in pretty much the same way.  In
> particular, i915_hangcheck_ring_idle will probably crash on all
> three rings.

Except that i915_hangcheck_elapsed should not be called from DRI code
paths, the whole error recovery code only works with GEM (we can't recover
the hardware if it is being poked directly by "userspace").
 
> FWIW after adding the INIT_LIST_HEAD to the init_dri function
> my kernel hasn't crashed yet (a couple of hours and counting).

Ah, yes. Need to pull some more code in from init_ringbuffer.

For my sanity can you check that the above patch also prevents the crash?
I'd rather not install a timer, and execute undesirable code paths, if we
don't need one.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/