linux-kernel - Re: [alsa-devel] [PATCH v4 1/3] ECI: input: introduce ECI accessory input driver

Open Source and information security mailing list archives

Message-ID: <1295525853.26257.21.camel@dell>
Date:	Thu, 20 Jan 2011 14:17:33 +0200
From:	Tapio Vihuri <tapio.vihuri@...ia.com>
To:	ext Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	randy.dunlap@...cle.com, alsa-devel@...a-project.org,
	samu.p.onkalo@...ia.com, peter.ujfalusi@...ia.com,
	linux-kernel@...r.kernel.org, ilkka.koskinen@...ia.com
Subject: Re: [alsa-devel] [PATCH v4 1/3] ECI: input: introduce ECI
 accessory input driver

On Thu, 2011-01-20 at 00:11 -0800, ext Dmitry Torokhov wrote:
> > How about KE_VSW case ? Shouldn't it be in the sparse_keymap_setup
> {}
> > also ?
> > 
> 
> Indeed. Does the patch below fix it?
> 

Hi.

Yes it does, thank you.

Patch working (as it obviously should) OK in my environment, so

> Thanks.
> 
> -- 
> Dmitry
> 
> Input: sparse-keymap - fix KEY_VSW handling in sparse_keymap_setup
> 
> From: Dmitry Torokhov <dmitry.torokhov@...il.com>
> 
> We were forgetting to set up device capabilities for KEY_VSW entries.
> 
> Reported-by: Tapio Vihuri <tapio.vihuri@...ia.com> 
> Signed-off-by: Dmitry Torokhov <dtor@...l.ru>

Tested-by: Tapio Vihuri <tapio.vihuri@...ia.com> 

> ---
> 
>  drivers/input/sparse-keymap.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> 
> diff --git a/drivers/input/sparse-keymap.c
> b/drivers/input/sparse-keymap.c
> index a29a7812..7729e54 100644
> --- a/drivers/input/sparse-keymap.c
> +++ b/drivers/input/sparse-keymap.c
> @@ -201,6 +201,7 @@ int sparse_keymap_setup(struct input_dev *dev,
>                         break;
>  
>                 case KE_SW:
> +               case KE_VSW:
>                         __set_bit(EV_SW, dev->evbit);
>                         __set_bit(entry->sw.code, dev->swbit);
>                         break;
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@...a-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel 
-- 
Tapsa
050 4876788

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives