linux-kernel - Re: [PATCH 01/10] Add yaffs2 file system: Allocation, block handling and bitmapping code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4D389111.4000206@bluewatersys.com>
Date:	Fri, 21 Jan 2011 08:46:25 +1300
From:	Ryan Mallon <ryan@...ewatersys.com>
To:	David Daney <ddaney@...iumnetworks.com>
CC:	Charles Manning <cdhmanning@...il.com>,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	akpm@...ux-foundation.org
Subject: Re: [PATCH 01/10] Add yaffs2 file system: Allocation, block handling
 and bitmapping code

On 01/20/2011 09:37 AM, David Daney wrote:
> On 01/19/2011 12:25 PM, Ryan Mallon wrote:
>> On 01/14/2011 04:06 PM, Charles Manning wrote:
> [...]
>>> +    if (!allocator) {
>>> +        YBUG();
>>> +        return;
>>> +    }
>>
>> You don't need this bug, the dereference of allocator below will oops
>> with all the same information as bug.
>>
> 
> Is that true for nommu systems too?

Actually, I'm not too sure. I understood that best practice was to avoid
putting BUG in places that will normally oops. Maybe someone can shed
some light on this?

~Ryan

-- 
Bluewater Systems Ltd - ARM Technology Solution Centre

Ryan Mallon         		5 Amuri Park, 404 Barbadoes St
ryan@...ewatersys.com         	PO Box 13 889, Christchurch 8013
http://www.bluewatersys.com	New Zealand
Phone: +64 3 3779127		Freecall: Australia 1800 148 751
Fax:   +64 3 3779135			  USA 1800 261 2934
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/