linux-kernel - Re: [PATCH 09/10] Add yaffs2 file system: Linux glue code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1101202111450.11854@swampdragon.chaosbits.net>
Date:	Thu, 20 Jan 2011 21:14:30 +0100 (CET)
From:	Jesper Juhl <jj@...osbits.net>
To:	Charles Manning <cdhmanning@...il.com>
cc:	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	akpm@...ux-foundation.org
Subject: Re: [PATCH 09/10] Add yaffs2 file system: Linux glue code

On Fri, 14 Jan 2011, Charles Manning wrote:

> Signed-off-by: Charles Manning <cdhmanning@...il.com>
> ---
...
> +static int yaffs_setxattr(struct dentry *dentry, const char *name,
> +                  const void *value, size_t size, int flags)
> +{
> +       struct inode *inode = dentry->d_inode;
> +       int error = 0;
> +       struct yaffs_dev *dev;
> +       struct yaffs_obj *obj = yaffs_inode_to_obj(inode);
> +

You only use the local variable 'inode' in the call to 
yaffs_inode_to_obj(), so you could get rid of that local variable and just 
do
    struct yaffs_obj *obj = yaffs_inode_to_obj(dentry->d_inode);
this applies to a few other function in this file as well.


-- 
Jesper Juhl <jj@...osbits.net>            http://www.chaosbits.net/
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/