linux-kernel - Re: [PATCH v7.1] block: Coordinate flush requests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110121064149.GH27381@tux1.beaverton.ibm.com>
Date:	Thu, 20 Jan 2011 22:41:49 -0800
From:	"Darrick J. Wong" <djwong@...ibm.com>
To:	Tejun Heo <tj@...nel.org>
Cc:	Shaohua Li <shli@...nel.org>, Jens Axboe <axboe@...nel.dk>,
	"Theodore Ts'o" <tytso@....edu>, Neil Brown <neilb@...e.de>,
	Andreas Dilger <adilger.kernel@...ger.ca>,
	Jan Kara <jack@...e.cz>, Mike Snitzer <snitzer@...hat.com>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Keith Mannthey <kmannth@...ibm.com>,
	Mingming Cao <cmm@...ibm.com>, linux-ext4@...r.kernel.org,
	Ric Wheeler <rwheeler@...hat.com>,
	Christoph Hellwig <hch@....de>, Josef Bacik <josef@...hat.com>
Subject: Re: [PATCH v7.1] block: Coordinate flush requests

On Thu, Jan 20, 2011 at 08:13:41PM +0100, Tejun Heo wrote:
> On Thu, Jan 20, 2011 at 07:50:57PM +0100, Tejun Heo wrote:
> > Hello,
> > 
> > On Tue, Jan 18, 2011 at 09:12:55AM +0800, Shaohua Li wrote:
> > > This makes sense. would it possible N flush data payloads delay the
> > > first request?
> > 
> > I ended up with a different design.  Still buggy.  It triggers a weird
> > oops under stress test but other than that things generally seem to
> > work as expected.  Please read the comment at the top of blk-flush.c
> > for more info.  I'll post properly after more testing and debugging.
> 
> The oops was caused by debugging code I put in (not posted together).
> It runs fine without it, so if you have some time, please give it a
> spin.

Seems to run without incident on my storage test arrays.  The fsync-happy
performance numbers are comparable to previous iterations of flush patches.
Looks good, thank you!

--D
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/