linux-kernel - Re: [PATCH 0/7] Nexus One Support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 21 Jan 2011 20:58:21 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Daniel Walker <dwalker@...eaurora.org>
Cc:	Ted Ts'o <tytso@....edu>, Pekka Enberg <penberg@...nel.org>,
	Dima Zavin <dmitriyz@...gle.com>,
	Jesse Barnes <jbarnes@...tuousgeek.org>,
	Joe Perches <joe@...ches.com>, linux-arm-msm@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	davidb@...eaurora.org
Subject: Re: [PATCH 0/7] Nexus One Support

On Fri, Jan 21, 2011 at 04:03:13PM -0800, Daniel Walker wrote:
> 
> right, but it wasn't a cherrypick which was explain in the thread. So
> there's no wrongs here ..

I'm sorry Daniel, but you are absolutely wrong!

Did you come up with the logic of this code, or did you take someone
else's code and just massage it until it worked?

If you took someone else's code, where are their Signed-off-by's?

Just look at what I did recently with Lai's rt-mutex clean up patch. I
ported it to the PREEMPT_RT (-rt) patch set. That port took me a week to
do. I had to add a bunch of code to make it work. When it was finished,
did I claim author of it? No! I left Lai as the author and simply added:

 [ Ported to the -rt patch set by Steven Rostedt ]

Take a look at the changes.

  Here's the patch I started with:

https://patchwork.kernel.org/patch/477841/

  Here's what I ended with (all my changes)

https://patchwork.kernel.org/patch/470171/

Do a diff of the two. There was a lot of work going into that. But I did
not come up with change to the algorithm that Lai did, so I kept him as
author. I just added my insert in the change log and added my own SoB
(including his).

If I repaint a Picasso, can I call it a Rostedt?

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/