linux-kernel - Re: [PATCH] tpm: fix panic caused by "tpm: Autodetect itpm devices"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LRH.2.00.1101241130460.30744@tundra.namei.org>
Date:	Mon, 24 Jan 2011 11:31:17 +1100 (EST)
From:	James Morris <jmorris@...ei.org>
To:	Olof Johansson <olof@...om.net>
cc:	linux-kernel@...r.kernel.org,
	Debora Velarde <debora@...ux.vnet.ibm.com>,
	Rajiv Andrade <srajiv@...ux.vnet.ibm.com>,
	Marcel Selhorst <m.selhorst@...rix.com>,
	tpmdd-devel@...ts.sourceforge.net,
	Matthew Garrett <mjg@...hat.com>,
	linux-security-module@...r.kernel.org
Subject: Re: [PATCH] tpm: fix panic caused by "tpm: Autodetect itpm
 devices"

On Thu, 20 Jan 2011, Olof Johansson wrote:

> On Thu, Jan 6, 2011 at 7:24 PM, Olof Johansson <olof@...om.net> wrote:
> > commit 3f0d3d016d89a5efb8b926d4707eb21fa13f3d27 adds a check for
> > PNP device id to the common tpm_tis_init() function, which in some
> > cases (force=1) will be called without the device being a member of
> > a pnp_dev. Oopsing and panics ensue.
> >
> > Move the test up to before the call to tpm_tis_init(), since it
> > just modifies a global variable anyway.

Applied to
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/security-testing-2.6#for-linus

-- 
James Morris
<jmorris@...ei.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/