linux-kernel - Re: [RFC][PATCH v3 2/6] encrypted-keys: added additional debug messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5456.1296038969@redhat.com>
Date:	Wed, 26 Jan 2011 10:49:29 +0000
From:	David Howells <dhowells@...hat.com>
To:	Roberto Sassu <roberto.sassu@...ito.it>
Cc:	dhowells@...hat.com, linux-security-module@...r.kernel.org,
	keyrings@...ux-nfs.org, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org, jmorris@...ei.org,
	zohar@...ux.vnet.ibm.com, safford@...son.ibm.com,
	ramunno@...ito.it, tyhicks@...ux.vnet.ibm.com,
	kirkland@...onical.com
Subject: Re: [RFC][PATCH v3 2/6] encrypted-keys: added additional debug messages

Roberto Sassu <roberto.sassu@...ito.it> wrote:

> +		pr_err("encrypted_key: insufficient parameters specified\n");

I think pr_err() is probably too high a message level.  This is a user error
not a kernel error.  I would recommend something like pr_info() or possibly
pr_debug().

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/