linux-kernel - Re: [PATCH] firmware_classs: change val uevent's type to bool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110126101556.GA16446@suse.de>
Date:	Wed, 26 Jan 2011 18:15:56 +0800
From:	Greg KH <gregkh@...e.de>
To:	Bob Liu <lliubbo@...il.com>
Cc:	"Berg, Johannes" <johannes.berg@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"chrisw@...s-sol.org" <chrisw@...s-sol.org>,
	"Winkler, Tomas" <tomas.winkler@...el.com>,
	"dmitry.torokhov@...il.com" <dmitry.torokhov@...il.com>
Subject: Re: [PATCH] firmware_classs: change val uevent's type to bool

On Wed, Jan 26, 2011 at 06:03:32PM +0800, Bob Liu wrote:
> On Wed, Jan 26, 2011 at 5:56 PM, Berg, Johannes <johannes.berg@...el.com> wrote:
> > @@ -463,7 +463,8 @@ fw_create_instance(struct firmware *firmware, const char *fw_name,
> >        f_dev->parent = device;
> >        f_dev->class = &firmware_class;
> >
> > -       dev_set_uevent_suppress(f_dev, true);
> > +       if (uevent)
> > +               dev_set_uevent_suppress(f_dev, true);
> >
> > Everything but this is a no-op basically, but you didn't even describe this change?
> >
> 
> 
> Hmm.. Sorry for that, but I mentioned that by "fix a place missing
> uevent check".
> I added this check because I think it should be paired with following
> dev_set_uevent_suppress(f_dev, false).

That's fine, but please, split that out into a separate patch.

Remember, a patch should only do one thing.

Please resend this as two patches and I will be glad to queue it up.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/