linux-kernel - Re: [PATCH 4/4] x86, amd: Support L3 Cache Partitioning on AMD family 0x15 CPUs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110126170532.GG877@escobedo.osrc.amd.com>
Date:	Wed, 26 Jan 2011 18:05:32 +0100
From:	Hans Rosenfeld <hans.rosenfeld@....com>
To:	Ingo Molnar <mingo@...e.hu>
CC:	"hpa@...or.com" <hpa@...or.com>,
	"tglx@...utronix.de" <tglx@...utronix.de>,
	"Herrmann3, Andreas" <Andreas.Herrmann3@....com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"x86@...nel.org" <x86@...nel.org>
Subject: Re: [PATCH 4/4] x86, amd: Support L3 Cache Partitioning on AMD
 family 0x15 CPUs

On Wed, Jan 26, 2011 at 05:56:37AM -0500, Ingo Molnar wrote:
> 
> * Hans Rosenfeld <hans.rosenfeld@....com> wrote:
> 
> > L3 Cache Partitioning allows selecting which of the 4 L3 subcaches can
> > be used for evictions by the L2 cache of each compute unit. By writing a
> > 4-bit hexadecimal mask into the the sysfs file /sys/devices/system/cpu/\
> > cpuX/cache/index3/subcaches, the user can set the enabled subcaches for
> > a CPU. The settings are directly read from and written to the hardware,
> > so there is no way to have contradicting settings for two CPUs belonging
> > to the same compute unit. Writing will always overwrite any previous
> > setting for a compute unit.
> > 
> > Signed-off-by: Hans Rosenfeld <hans.rosenfeld@....com>
> > ---
> >  arch/x86/include/asm/amd_nb.h         |    3 +
> >  arch/x86/kernel/amd_nb.c              |   55 +++++++++++++++++++++++++
> >  arch/x86/kernel/cpu/intel_cacheinfo.c |   73 +++++++++++++++++++++++++++-----
> >  3 files changed, 119 insertions(+), 12 deletions(-)
> 
> I have picked up the other 3 patches, but this one causes this build failure:
> 
>  arch/x86/kernel/amd_nb.c: In function ?amd_get_subcaches?:
>  arch/x86/kernel/amd_nb.c:129:36: error: ?struct cpuinfo_x86? has no member named ?compute_unit_id?
>  arch/x86/kernel/amd_nb.c: In function ?amd_set_subcaches?:
>  arch/x86/kernel/amd_nb.c:154:28: error: ?struct cpuinfo_x86? has no member named ?compute_unit_id?
>  arch/x86/kernel/amd_nb.c:155:36: error: ?struct cpuinfo_x86? has no member named ?compute_unit_id?
>  arch/x86/kernel/amd_nb.c: In function ?amd_get_subcaches?:
>  arch/x86/kernel/amd_nb.c:130:1: warning: control reaches end of non-void function

Hrmpf. CONFIG_SMP.

Sorry for the noise, fixed patch will follow shortly.


Hans


-- 
%SYSTEM-F-ANARCHISM, The operating system has been overthrown

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/