linux-kernel - Re: One (possible) x86 get_user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1296145502.15234.235.camel@laptop>
Date:	Thu, 27 Jan 2011 17:25:02 +0100
From:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
To:	Jan Beulich <JBeulich@...ell.com>
Cc:	Xiaowei Yang <xiaowei.yang@...wei.com>,
	Nick Piggin <npiggin@...nel.dk>, fanhenglong@...wei.com,
	Kaushik Barde <kbarde@...wei.com>,
	Kenneth Lee <liguozhu@...wei.com>,
	linqaingmin <linqiangmin@...wei.com>, wangzhenguo@...wei.com,
	Wu Fengguang <fengguang.wu@...el.com>,
	"xen-devel@...ts.xensource.com" <xen-devel@...ts.xensource.com>,
	linux-kernel@...r.kernel.org
Subject: Re: One (possible) x86 get_user_pages bug

On Thu, 2011-01-27 at 16:07 +0000, Jan Beulich wrote:
> 
> Nick, based on your doing of the initial implementation, would
> you be able to estimate whether disabling get_user_pages_fast()
> altogether for Xen would be performing measurably worse than
> adding the locks (but continuing to avoid acquiring mm->mmap_sem)
> as suggested by Xiaowei? That's of course only if the latter is correct
> at all, of which I haven't fully convinced myself yet. 

Adding the lock will result in deadlocks, __get_user_pages_fast() is
used from NMI context.

Then again, I've got no clue if Xen even has NMIs..
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/