linux-kernel - Re: [PATCH 1/7] sysdev: Do not register with sysdev when erroring on add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110131221659.GA14918@kroah.com>
Date:	Mon, 31 Jan 2011 14:16:59 -0800
From:	Greg KH <greg@...ah.com>
To:	Borislav Petkov <bp@...64.org>
Cc:	x86@...nel.org, linux-kernel@...r.kernel.org,
	Borislav Petkov <borislav.petkov@....com>,
	Greg Kroah-Hartman <gregkh@...e.de>
Subject: Re: [PATCH 1/7] sysdev: Do not register with sysdev when erroring
 on add

On Mon, Jan 24, 2011 at 04:28:57PM +0100, Borislav Petkov wrote:
> From: Borislav Petkov <borislav.petkov@....com>
> 
> When encountering an error while executing the driver's ->add method, we
> should cancel registration and unwind what we've regged so far. The low
> level ->add methods do return proper error codes but those aren't looked
> at in sysdev_driver_register(). Fix that by sharing the unregistering
> code.

Have you actually hit this before?  If so, where?

> Also, fixup warning messages formatting while at it.

Please, no, one patch per thing.  Please break this up into two
different patches.

And, in the future, let me know that you need this for other work.
Actually, why did you send this to Ingo in your pull request?  What does
your microcode patches need from this patch?  It should go through my
tree, especially as there is other sysdev work happening at the moment.

so, no, please don't send this on to anyone else right now.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/