linux-kernel - Re: [PATCH 1/7] sysdev: Do not register with sysdev when erroring on add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 31 Jan 2011 23:33:19 +0100
From:	Borislav Petkov <bp@...64.org>
To:	Greg KH <greg@...ah.com>, Ingo Molnar <mingo@...e.hu>
Cc:	"x86@...nel.org" <x86@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Greg Kroah-Hartman <gregkh@...e.de>
Subject: Re: [PATCH 1/7] sysdev: Do not register with sysdev when erroring
 on add

On Mon, Jan 31, 2011 at 05:16:59PM -0500, Greg KH wrote:
> On Mon, Jan 24, 2011 at 04:28:57PM +0100, Borislav Petkov wrote:
> > From: Borislav Petkov <borislav.petkov@....com>
> > 
> > When encountering an error while executing the driver's ->add method, we
> > should cancel registration and unwind what we've regged so far. The low
> > level ->add methods do return proper error codes but those aren't looked
> > at in sysdev_driver_register(). Fix that by sharing the unregistering
> > code.
> 
> Have you actually hit this before?  If so, where?

Sorta. I want to be paranoid when loading the microcode image file and
in patch 3/7 (http://marc.info/?l=linux-kernel&m=129588287409770) I
propagate the error in case loading the microcode fails. If we don't
cleanup here, the driver remains loaded and takes up resources. And if
you load it again, you get a sysfs warning about duplicated entries.

> > Also, fixup warning messages formatting while at it.
> 
> Please, no, one patch per thing.  Please break this up into two
> different patches.

Yes, will do.

> And, in the future, let me know that you need this for other work.

Will do.

> Actually, why did you send this to Ingo in your pull request?  What does
> your microcode patches need from this patch?  It should go through my
> tree, especially as there is other sysdev work happening at the moment.

Sorry about that, I did not mean to bypass/offend you in any way.

> so, no, please don't send this on to anyone else right now.

Do you need the patches rediffed against a some tree of yours?

@Ingo: please disregard my pull request from today:
http://marc.info/?l=linux-kernel&m=129648061017908

Guys, sorry again if I've caused any trouble.

Thanks.

-- 
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/