linux-kernel - Re: [Patch] rcupdate: remove dead code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110131075900.GC2145@linux.vnet.ibm.com>
Date:	Sun, 30 Jan 2011 23:59:00 -0800
From:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:	Amerigo Wang <amwang@...hat.com>
Cc:	linux-kernel@...r.kernel.org, Dipankar Sarma <dipankar@...ibm.com>
Subject: Re: [Patch] rcupdate: remove dead code

On Sun, Jan 30, 2011 at 06:23:08PM +0800, Amerigo Wang wrote:
> DEBUG_OBJECTS_RCU_HEAD depends on PREEMPT, so #ifndef CONFIG_PREEMPT
> is totally useless in kernel/rcupdate.c.

Queued, thank you, Amerigo!

I added a patch on top of this commenting why DEBUG_OBJECTS_RCU_HEAD
is disallowed if !PREEMPT, FYI.

							Thanx, Paul

> Signed-off-by: WANG Cong <amwang@...hat.com>
> Cc: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>
> 
> 
> ---
> diff --git a/kernel/rcupdate.c b/kernel/rcupdate.c
> index a23a57a..afd21d1 100644
> --- a/kernel/rcupdate.c
> +++ b/kernel/rcupdate.c
> @@ -215,10 +215,6 @@ static int rcuhead_fixup_free(void *addr, enum debug_obj_state state)
>  		 * If we detect that we are nested in a RCU read-side critical
>  		 * section, we should simply fail, otherwise we would deadlock.
>  		 */
> -#ifndef CONFIG_PREEMPT
> -		WARN_ON(1);
> -		return 0;
> -#else
>  		if (rcu_preempt_depth() != 0 || preempt_count() != 0 ||
>  		    irqs_disabled()) {
>  			WARN_ON(1);
> @@ -229,7 +225,6 @@ static int rcuhead_fixup_free(void *addr, enum debug_obj_state state)
>  		rcu_barrier_bh();
>  		debug_object_free(head, &rcuhead_debug_descr);
>  		return 1;
> -#endif
>  	default:
>  		return 0;
>  	}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/