linux-kernel - Re: [PATCH] fs: Correctly check d_alloc_name() return code in devpts_pty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4D4B0611.5010509@gmail.com>
Date:	Thu, 03 Feb 2011 22:46:25 +0300
From:	"avagin@...il.com" <avagin@...il.com>
To:	Andrey Vagin <avagin@...nvz.org>
CC:	Al Viro <viro@...iv.linux.org.uk>, Tejun Heo <tj@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs: Correctly check d_alloc_name() return code in devpts_pty_new

Sorry, I found one more similar place, so will send another patch.

On 02/03/2011 07:07 PM, Andrey Vagin wrote:
> d_alloc_name return NULL in case error, but we expect errno in
> devpts_pty_new.
>
> http://bugzilla.openvz.org/show_bug.cgi?id=1758
>
> Signed-off-by: Andrey Vagin<avagin@...nvz.org>
> ---
>   fs/devpts/inode.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/devpts/inode.c b/fs/devpts/inode.c
> index 1bb547c..8392c8c 100644
> --- a/fs/devpts/inode.c
> +++ b/fs/devpts/inode.c
> @@ -501,7 +501,7 @@ int devpts_pty_new(struct inode *ptmx_inode, struct tty_struct *tty)
>   	mutex_lock(&root->d_inode->i_mutex);
>
>   	dentry = d_alloc_name(root, s);
> -	if (!IS_ERR(dentry)) {
> +	if (dentry) {
>   		d_add(dentry, inode);
>   		fsnotify_create(root->d_inode, dentry);
>   	}

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/