linux-kernel - Re: [PATCH 11/12] n_tracerouter and n

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4D51AFBA.9080409@xenotime.net>
Date:	Tue, 08 Feb 2011 13:03:54 -0800
From:	Randy Dunlap <rdunlap@...otime.net>
To:	james_p_freyensee@...ux.intel.com
CC:	gregkh@...e.de, linux-kernel@...r.kernel.org,
	suhail.ahmed@...el.com
Subject: Re: [PATCH 11/12] n_tracerouter and n_tracesink Kconfig.

On 2/8/2011 11:34 AM, james_p_freyensee@...ux.intel.com wrote:
> From: J Freyensee<james_p_freyensee@...ux.intel.com>
>
> This patch allows n_tracerouter and n_tracesink ldisc drivers
> to be configured in menuconfig.

s/menuconfig/kconfig tools/


> Signed-off-by: J Freyensee<james_p_freyensee@...ux.intel.com>
> ---
>   drivers/char/Kconfig |   32 ++++++++++++++++++++++++++++++++
>   1 files changed, 32 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig
> index 43d3395..02b9be2 100644
> --- a/drivers/char/Kconfig
> +++ b/drivers/char/Kconfig
> @@ -289,6 +289,38 @@ config N_GSM
>   	  This line discipline provides support for the GSM MUX protocol and
>   	  presents the mux as a set of 61 individual tty devices.
>
> +config TRACE_ROUTER
> +        tristate "Trace data router for MIPI P1149.7 cJTAG standard"
> +                depends on TRACE_SINK
> +                default Y

Indentation above and on the "default" below looks flaky.
Should line up with "tristate".

> +        ---help---
> +          The trace router uses the Linux tty line discipline framework to
> +          route trace data coming from a tty port (say UART for example) to
> +           the trace sink line discipline driver and to another tty port(say USB).
> +           This is part of a solution for the MIPI P1149.7, compact JTAG,
> +           standard, which is for debugging mobile devices. The PTI driver in
> +           drivers/misc/pti.c defines the majority of this MIPI solution.
> +
> +          You should select this driver if the target kernel is meant for
> +          a mobile device containing a modem.  Then you will need to select
> +          "Trace data sink for MIPI P1149.7 cJTAG standard" line discipline
> +          driver.
> +
> +config TRACE_SINK
> +        tristate "Trace data sink for MIPI P1149.7 cJTAG standard"
> +                default Y
> +        ---help---
> +          The trace sink uses the Linux line discipline framework to receive
> +          trace data coming from the trace router line discipline driver
> +          to a user-defined tty port target, like USB.
> +          This is to provide a way to extract modem trace data on
> +          devices that do not have a PTI HW module, or just need modem
> +          trace data to come out of a different HW output port.
> +          This is part of a solution for the P1149.7, compact JTAG, standard.
> +
> +          If you select this option, you need to select
> +          "Trace data router for MIPI P1149.7 cJTAG standard".
> +
>   config RISCOM8
>   	tristate "SDL RISCom/8 card support"
>   	depends on SERIAL_NONSTANDARD

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/