[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <AANLkTi=MX0h-YU_Y_LSgZ1gLxS0iXSDGbRyHx4u4TVC1@mail.gmail.com>
Date: Thu, 10 Feb 2011 20:40:54 +0800
From: Eric Miao <eric.y.miao@...il.com>
To: Trilok Soni <tsoni@...eaurora.org>
Cc: Anirudh Ghayal <aghayal@...eaurora.org>,
linux-kernel@...r.kernel.org, linux-input@...r.kernel.org,
rtc-linux@...glegroups.com, linux-arm-msm@...r.kernel.org,
Dmitry Torokhov <dmitry.torokhov@...il.com>
Subject: Re: [RFC v2 PATCH 1/7] matrix_keypad: Increase the max limit of rows
and columns
On Thu, Feb 10, 2011 at 8:20 PM, Trilok Soni <tsoni@...eaurora.org> wrote:
> Hi Dmitry,
>
> On 2/9/2011 1:32 PM, Eric Miao wrote:
>> On Tue, Feb 1, 2011 at 9:47 PM, Anirudh Ghayal <aghayal@...eaurora.org> wrote:
>>> From: Trilok Soni <tsoni@...eaurora.org>
>>>
>>> Some keyboard controller have support for more than
>>> 16 columns and rows. Moving this value to 32.
>>>
>>> Cc: Eric Miao <eric.y.miao@...il.com>
>>> Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>
>>> Signed-off-by: Trilok Soni <tsoni@...eaurora.org>
>>
>> This looks good to me, as long as the bits don't exceed 256, which
>> is used in the #KEY() macro. So far, 32 looks to be a sane number
>> to me, unless we have further requirement to get this larger.
>>
>> Acked-by: Eric Miao <eric.y.miao@...il.com>
>>
>
> Are you going to pick up this patch only from the series you want us to get
> it submitted it separately?
I believe Dmitry will pick this series once all the patches are reviewed?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists