linux-kernel - Re: [RFC v2 PATCH 1/7] matrix_keypad: Increase the max limit of rows and columns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4D53D7FE.9070206@codeaurora.org>
Date:	Thu, 10 Feb 2011 17:50:14 +0530
From:	Trilok Soni <tsoni@...eaurora.org>
To:	Eric Miao <eric.y.miao@...il.com>
CC:	Anirudh Ghayal <aghayal@...eaurora.org>,
	linux-kernel@...r.kernel.org, linux-input@...r.kernel.org,
	rtc-linux@...glegroups.com, linux-arm-msm@...r.kernel.org,
	Dmitry Torokhov <dmitry.torokhov@...il.com>
Subject: Re: [RFC v2 PATCH 1/7] matrix_keypad: Increase the max limit of rows
 and columns

Hi Dmitry,

On 2/9/2011 1:32 PM, Eric Miao wrote:
> On Tue, Feb 1, 2011 at 9:47 PM, Anirudh Ghayal <aghayal@...eaurora.org> wrote:
>> From: Trilok Soni <tsoni@...eaurora.org>
>>
>> Some keyboard controller have support for more than
>> 16 columns and rows. Moving this value to 32.
>>
>> Cc: Eric Miao <eric.y.miao@...il.com>
>> Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>
>> Signed-off-by: Trilok Soni <tsoni@...eaurora.org>
> 
> This looks good to me, as long as the bits don't exceed 256, which
> is used in the #KEY() macro. So far, 32 looks to be a sane number
> to me, unless we have further requirement to get this larger.
> 
> Acked-by: Eric Miao <eric.y.miao@...il.com>
> 

Are you going to pick up this patch only from the series you want us to get
it submitted it separately?

---Trilok Soni

-- 
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/