linux-kernel - Re: [Patch] idle governor: Avoid lock acquisition to read pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1297454630.2645.277.camel@schen9-DESK>
Date:	Fri, 11 Feb 2011 12:03:50 -0800
From:	Tim Chen <tim.c.chen@...ux.intel.com>
To:	James Bottomley <James.Bottomley@...e.de>
Cc:	"Rafael J. Wysocki" <rjw@...k.pl>,
	mark gross <markgross@...gnar.org>,
	David Alan Gilbert <linux@...blig.org>,
	linux-kernel@...r.kernel.org, Len <len.brown@...el.com>,
	Andi Kleen <ak@...ux.intel.com>,
	Arjan van de Ven <arjan@...ux.intel.com>,
	Len Brown <lenb@...nel.org>,
	Linux PM mailing list <linux-pm@...ts.linux-foundation.org>
Subject: Re: [Patch] idle governor: Avoid lock acquisition to read pm_qos
 before entering idle

On Fri, 2011-02-11 at 13:33 -0600, James Bottomley wrote:
> On Fri, 2011-02-11 at 11:27 -0800, Tim Chen wrote:
> > On Fri, 2011-02-11 at 20:22 +0100, Rafael J. Wysocki wrote:
> > 
> > > 
> > > Thanks, but I'd put that comment before the structure definition with the
> > > "NOTE:" prefix and I think you should explain the reason why that field
> > > shouldn't be changed to 64-bits.
> > > 
> > 
> > Either you or James want to suggest a comment on why the field shouldn't
> > be changed to 64-bits to be placed there?
> 
> /*
>  * Note: The lockless read read path depends on the CPU accessing 
>  * target_value atomically.  Atomic access is only guaranteed on all CPU
>  * types linux supports for 32 bit quantites
>  */
> 
> James
> 
> 

Thanks.  I will incorporate your suggested comment in an updated patch.

Tim


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/