linux-kernel - RE: Request (2nd) for unicore32 architecture codes to merge into linux-next

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <022d01cbc99a$63717e80$2a547b80$@mprc.pku.edu.cn>
Date:	Fri, 11 Feb 2011 11:18:40 +0800
From:	"Guan Xuetao" <gxt@...c.pku.edu.cn>
To:	"'Thomas Gleixner'" <tglx@...utronix.de>,
	"'Guan Xuetao'" <guanxuetao@...c.pku.edu.cn>
Cc:	<sfr@...b.auug.org.au>, "'Arnd Bergmann'" <arnd@...db.de>,
	<gregkh@...e.de>, <jbarnes@...tuousgeek.org>,
	<dmitry.torokhov@...il.com>, <dtor@...l.ru>,
	<linux-arch@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-next@...r.kernel.org>
Subject: RE: Request (2nd) for unicore32 architecture codes to merge into linux-next



> >  arch/unicore32/kernel/time.c                  |  148 +++++
> 
> static struct clock_event_device ckevt_puv3_osmr0 ...
> #ifdef CONFIG_ARCH_FPGA
>         .shift          = 18, /* correct shift val: 16, but warn_on_slowpath */
> #else
>         .shift          = 30,
> #endif
> 
> ....
>         ckevt_puv3_osmr0.mult =
>                 div_sc(CLOCK_TICK_RATE, NSEC_PER_SEC, ckevt_puv3_osmr0.shift);
> 
> Please use the function which calculates the optimizes mult/shift
> values for you depending on the clock frequency.
> 
> clockevents_calc_mult_shift() is your friend.
> 
> >  arch/unicore32/kernel/irq.c                   |  426 +++++++++++++
> 
> Please convert your irq_chips to the new function pointers:
> 
>        .mask -> .irq_mask
>        ...
> 
> The new functions replace the "unsigned int irq" argument with
> "struct irq_data *d".
> 
> So conversion for your chips is simply
> 
> s/unsigned int irq/struct irq_data *d/
> 
> and
> 
> s/irq/d->irq/ in the implementation.
> 
> Then your arch should select: GENERIC_HARDIRQS_NO_DEPRECATED
> 
> Otherwise I'm happy with your irq and time related patches.
> 
> Thanks,
> 
> 	tglx
Thanks Thomas. I will apply the advice and test it lator.

Guan Xuetao

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/