linux-kernel - Re: [PATCH] x86: fix section mismatch in reference from native_play

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110214133210.GC9137@aftab>
Date:	Mon, 14 Feb 2011 14:32:10 +0100
From:	Borislav Petkov <bp@...64.org>
To:	Sergey Senozhatsky <sergey.senozhatsky@...il.com>
Cc:	Ingo Molnar <mingo@...e.hu>, Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	"x86@...nel.org" <x86@...nel.org>, Tejun Heo <tj@...nel.org>,
	"Petkov, Borislav" <Borislav.Petkov@....com>,
	Suresh Siddha <suresh.b.siddha@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86: fix section mismatch in reference from
 native_play_dead

On Mon, Feb 14, 2011 at 07:32:44AM -0500, Sergey Senozhatsky wrote:
> > -int __cpuinit mwait_usable(const struct cpuinfo_x86 *c)
> > +int mwait_usable(const struct cpuinfo_x86 *c)
> >  {
> >  	u32 eax, ebx, ecx, edx;
> >  
> > 
> 
> `int mwait_usable(..)' is called from `void __cpuinit select_idle_routine(...)'
> 
> I think we still have section mismatch in this case. Is it correct?

Right, but mwait_usable() is not __cpuinit anymore and __cpuinit
functions should be able to call other functions without annotation,
methinks, no?

-- 
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/