| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20110215091239.GD3160@htj.dyndns.org> Date: Tue, 15 Feb 2011 10:12:39 +0100 From: Tejun Heo <tj@...nel.org> To: Andy Walls <awalls@...metrocast.net> Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>, linux-kernel@...r.kernel.org, linux-media@...r.kernel.org, stoth@...nellabs.com Subject: Re: cx23885-input.c does in fact use a workqueue.... Hello, On Mon, Feb 14, 2011 at 07:54:36PM -0500, Andy Walls wrote: > > 1. Just flush the work items explicitly using flush_work_sync(). > > That will do for now. > > > 2. Create a dedicated workqueue to serve as flushing domain. > > I have gotten reports of the IR Rx FIFO overflows for the CX23885 IR Rx > unit (the I2C connected one). I eventually should either set the Rx > FIFO service interrupt watermark down from 4 measurments to 1 > measurment, or use a kthread_worker with some higher priority to respond > to the IR Rx FIFO service interrupt. Hmmm... please consider playing with WQ_HIGHPRI before going forward with dedicated thread. > > The first would look like the following. Does this look correct? > > Yes, your patch below looks sane to me. > > Reviewed-by: Andy Walls <awalls@...metrocast.net> Thanks. Will send patch with proper description soon. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists