linux-kernel - Re: [PATCH] x86, numa: cleanup x86_acpi_numa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4D5C55DD.3050206@kernel.org>
Date:	Wed, 16 Feb 2011 14:55:25 -0800
From:	Yinghai Lu <yinghai@...nel.org>
To:	Tejun Heo <tj@...nel.org>
CC:	Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...e.hu>,
	"H. Peter Anvin" <hpa@...or.com>,
	David Rientjes <rientjes@...gle.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86, numa: cleanup x86_acpi_numa_init()

On 02/16/2011 02:49 PM, Tejun Heo wrote:
> On Wed, Feb 16, 2011 at 02:31:34PM -0800, Yinghai Lu wrote:
>> make it more readable. put valid checking together.
>>
>> Also restore old acpi_numa_init(). we don't need to touch it
>> because already have x86 own wrapper.
>>
>> Signed-off-by: Yinghai Lu <yinghai@...nel.org>
> 
> What's the point of this patch?  If someone else likes it, I don't
> object but I have no idea why this is any better than before.

before you added x86_acpi_numa_init(), you modified acpi_numa_init...

you really don't need to touch other acpi code, if we can limit that in x86 code.

Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/