linux-kernel - Re: [PATCH] x86, numa: refactoring numa_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110216230340.GF29600@atj.dyndns.org>
Date:	Thu, 17 Feb 2011 00:03:40 +0100
From:	Tejun Heo <tj@...nel.org>
To:	Yinghai Lu <yinghai@...nel.org>
Cc:	Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...e.hu>,
	"H. Peter Anvin" <hpa@...or.com>,
	David Rientjes <rientjes@...gle.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86, numa: refactoring numa_register_memblks

On Wed, Feb 16, 2011 at 02:53:02PM -0800, Yinghai Lu wrote:
> > Sorry, nack.  This squarely falls in the realm of bikeshedding and I
> > plan on collapsing init_memory_mapping_high() into the register
> > function.
> 
> no. init_memory_mapping_high now it is with early_node_map[], aka it
> is e820 and srat table overlapping one.

Hmmm... okay, I'll think more about it but currently it looks silly.
It isn't necessary for !NUMA and is done in rather convoluted way in
NUMA.  The name is misleading too.  There's nothing like mapped high
memory.  Maybe it would be better to use suffix like _above_4g.  At
any rate, I don't really see the point of moving those functions
calls.

The way I see it is that these things are inherently subjective.  When
you're writing or updating the part, it's natural to follow your own
preference.  When reviewing or working on other's code, trying to
enforce all those subjective details doesn't really help anyone.  Push
the ones with technical advantages; otherwise, just let it go.

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/