linux-kernel - please, remove the abuse of vfs_path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110217015350.GH22723@ZenIV.linux.org.uk>
Date:	Thu, 17 Feb 2011 01:53:50 +0000
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Tyler Hicks <tyhicks@...ux.vnet.ibm.com>
Cc:	linux-kernel@...r.kernel.org
Subject: please, remove the abuse of vfs_path_lookup() in ecryptfs

	commit 21edad32205e97dc7ccb81a85234c77e760364c8 (
ecryptfs: dont call lookup_one_len to avoid NULL nameidata) is badly
misguided.  The last thing we need is extra places where nameidata is
passed around.

	The current code is simply wrong - it's bypassing dcache
lookups in new_lower_dentry().  Besides, abuse of vfs_path_lookup()
here is a Bad Idea(tm).  No, filesystems are *not* allowed to die
if ->d_revalidate()/->lookup()/->create() are called with NULL
nameidata.  Eventually these methods will lose nameidata * anyway -
starting with ->d_revalidate() in the next cycle at the latest
(i.e. if we run into something really stinky in RCU mess, it might
happen before -final).

	Please revert that.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/