linux-kernel - Re: please, remove the abuse of vfs_path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110218034541.GE24444@boyd.l.tihix.com>
Date:	Thu, 17 Feb 2011 21:45:42 -0600
From:	Tyler Hicks <tyhicks@...ux.vnet.ibm.com>
To:	Al Viro <viro@...IV.linux.org.uk>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: please, remove the abuse of vfs_path_lookup() in ecryptfs

On Thu Feb 17, 2011 at 01:53:50AM +0000, Al Viro <viro@...IV.linux.org.uk> wrote:
> 	commit 21edad32205e97dc7ccb81a85234c77e760364c8 (
> ecryptfs: dont call lookup_one_len to avoid NULL nameidata) is badly
> misguided.  The last thing we need is extra places where nameidata is
> passed around.

Thanks, Al. I reverted that patch and pushed it to
git://git.kernel.org/pub/scm/linux/kernel/git/ecryptfs/ecryptfs-2.6.git#next

I'll get a pull request together for Linus in the next day or two.

> 
> 	The current code is simply wrong - it's bypassing dcache
> lookups in new_lower_dentry().  Besides, abuse of vfs_path_lookup()
> here is a Bad Idea(tm).  No, filesystems are *not* allowed to die
> if ->d_revalidate()/->lookup()/->create() are called with NULL
> nameidata.

I fixed the eCryptfs d_revalidate, lookup, and create paths to not choke
when handed NULL nameidata. I don't think we would have ever received
NULL nameidata since we don't allow eCryptfs on eCryptfs or export to
NFS.

Tyler

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/