linux-kernel - Re: [PATCH 1/3] perf events: fix WARN_ON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1298041291.5226.776.camel@laptop>
Date:	Fri, 18 Feb 2011 16:01:31 +0100
From:	Peter Zijlstra <peterz@...radead.org>
To:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>
Cc:	David Ahern <daahern@...co.com>, linux-perf-users@...r.kernel.org,
	linux-kernel@...r.kernel.org, mingo@...e.hu, paulus@...ba.org
Subject: Re: [PATCH 1/3] perf events: fix WARN_ON_ONCE for 64-bit raw data,
 SW events

On Fri, 2011-02-18 at 12:53 -0200, Arnaldo Carvalho de Melo wrote:
> 
> > So size should be changed to u64 rather than modifying the
> WARN_ON_ONCE?
> 
> Yeah, I guess so, 32-bit has to die it seems, gets in the way of
> testing
> :-) 

No!

1) don't use RAW unless you have to
2) you don't have to, goto 1
3) if you do anyway, ensure its properly padded

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/