linux-kernel - Re: [PATCH] Make msp7120

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4D610B3A.5070705@mvista.com>
Date:	Sun, 20 Feb 2011 15:38:18 +0300
From:	Sergei Shtylyov <sshtylyov@...sta.com>
To:	"Anoop P.A" <anoop.pa@...il.com>
CC:	ralf@...ux-mips.org, linux-mips@...ux-mips.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Make msp7120_reset generic

Hello.

On 18-02-2011 16:55, Anoop P.A wrote:

> From: Anoop P A<anoop.pa@...il.com>

> Remove platform dependency code from msp7120 reset code and make it generic.
> Now the code can be reused for other boards running msp71xx family SoC.

> Signed-off-by: Anoop P A<anoop.pa@...il.com>
[...]

> diff --git a/arch/mips/pmc-sierra/msp71xx/msp_setup.c b/arch/mips/pmc-sierra/msp71xx/msp_setup.c
> index fb37a10..4a6cc0d 100644
> --- a/arch/mips/pmc-sierra/msp71xx/msp_setup.c
> +++ b/arch/mips/pmc-sierra/msp71xx/msp_setup.c
> @@ -18,30 +18,33 @@
>
>   #include<msp_prom.h>
>   #include<msp_regs.h>
> +#include<msp_gpio_macros.h>
>
>   #if defined(CONFIG_PMC_MSP7120_GW)
> -#include<msp_regops.h>
> +	/* GPIO 9 is the 4th GPIO of register 3
> +	 */

    Not clear why you're using a multi-line comment where a single-one line 
one (and not indented) would be enough?

> @@ -78,49 +81,56 @@ void msp7120_reset(void)
>   	/* Wait a bit for the DDRC to settle */
>   	for (i = 0; i < 100000000; i++);
>
> -#if defined(CONFIG_PMC_MSP7120_GW)
> +#if defined MSP_BOARD_RESET_GPIO

    Hm, didn't know that the 'defined' syntax without parens is valid too...

> @@ -141,9 +151,7 @@ void msp_power_off(void)
>
>   void __init plat_mem_setup(void)
>   {
> -	_machine_restart = msp_restart;
> -	_machine_halt = msp_halt;
> -	pm_power_off = msp_power_off;
> +/*TODO: Move mem setup here */

    This line should be indented.

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/