linux-kernel - Re: [PATCH] random: update interface comments to reflect reality

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110221104326.GA28805@gondor.apana.org.au>
Date:	Mon, 21 Feb 2011 21:43:27 +1100
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Matt Mackall <mpm@...enic.com>
Cc:	Jarod Wilson <jarod@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] random: update interface comments to reflect reality

On Thu, Feb 17, 2011 at 04:29:14PM -0600, Matt Mackall wrote:
> On Thu, 2011-02-17 at 17:23 -0500, Jarod Wilson wrote:
> > At present, the comment header in random.c makes no mention of
> > add_disk_randomness, and instead, suggests that disk activity adds to the
> > random pool by way of add_interrupt_randomness, which appears to not have
> > been the case since sometime prior to the existence of git, and even prior
> > to bitkeeper. Didn't look any further back. At least, as far as I can
> > tell, there are no storage drivers setting IRQF_SAMPLE_RANDOM, which is a
> > requirement for add_interrupt_randomness to trigger, so the only way for a
> > disk to contribute entropy is by way of add_disk_randomness. Update
> > comments accordingly, complete with special mention about solid state
> > drives being a crappy source of entropy (see e2e1a148bc for reference).
> > 
> > Signed-off-by: Jarod Wilson <jarod@...hat.com>
> 
> Sure. Herbert, let's route this through your crypto tree.
> 
> Acked-by: Matt Mackall <mpm@...enic.com>

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/