linux-kernel - Re: [tip:irq/core] genirq: Add IRQCHIP_SET_TYPE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.1102211418220.2701@localhost6.localdomain6>
Date:	Mon, 21 Feb 2011 14:18:53 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Lars-Peter Clausen <lars@...afoo.de>
cc:	linux-kernel@...r.kernel.org, mingo@...hat.com, hpa@...or.com,
	linus.walleij@...ricsson.com, linux-tip-commits@...r.kernel.org
Subject: Re: [tip:irq/core] genirq: Add IRQCHIP_SET_TYPE_MASKED flag

On Mon, 21 Feb 2011, Lars-Peter Clausen wrote:

>  > @@ -588,11 +596,13 @@ int __irq_set_trigger(struct irq_desc *desc, unsigned
> int irq,
> >  
> >  		if (chip != desc->irq_data.chip)
> >  			irq_chip_set_defaults(desc->irq_data.chip);
> > -		return 0;
> > +		ret = 0;
> 
> I've just tested the patch and noticed that a 'break' is missing here.

Grmbl. Thanks for catching that !

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/