linux-kernel - Re: [PATCH 1/8] Fix interleaving for transparent hugepages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4D63EE38.9000008@linux.intel.com>
Date:	Tue, 22 Feb 2011 09:11:20 -0800
From:	Andi Kleen <ak@...ux.intel.com>
To:	Christoph Lameter <cl@...ux.com>
CC:	Andi Kleen <andi@...stfloor.org>, akpm@...ux-foundation.org,
	linux-mm@...ck.org, linux-kernel@...r.kernel.org,
	aarcange@...hat.com, lwoodman@...hat.com
Subject: Re: [PATCH 1/8] Fix interleaving for transparent hugepages

On 2/22/2011 7:34 AM, Christoph Lameter wrote:
> On Mon, 21 Feb 2011, Andi Kleen wrote:
>
>> @@ -1830,7 +1830,7 @@ alloc_pages_vma(gfp_t gfp, int order, struct vm_area_struct *vma,
>>   	if (unlikely(pol->mode == MPOL_INTERLEAVE)) {
>>   		unsigned nid;
>>
>> -		nid = interleave_nid(pol, vma, addr, PAGE_SHIFT);
>> +		nid = interleave_nid(pol, vma, addr, PAGE_SHIFT<<  order);
> Should be PAGE_SHIFT + order.

Oops. True. Thanks.

-Andi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/