| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <201102221811.58441.arnd@arndb.de> Date: Tue, 22 Feb 2011 18:11:58 +0100 From: Arnd Bergmann <arnd@...db.de> To: "Guan Xuetao" <gxt@...c.pku.edu.cn> Cc: dmitry.torokhov@...il.com, linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org, "'Greg KH'" <greg@...ah.com> Subject: Re: [PATCH 11/12] unicore32 machine related files: ps2 driver On Tuesday 22 February 2011, Guan Xuetao wrote: > diff --git a/drivers/input/serio/i8042-unicore32io.h b/drivers/input/serio/i8042-unicore32io.h > index 2cdd872..9350843 100644 > --- a/drivers/input/serio/i8042-unicore32io.h > +++ b/drivers/input/serio/i8042-unicore32io.h > @@ -29,11 +29,11 @@ > /* > * Register numbers. > */ > -#define I8042_COMMAND_REG ((volatile void __iomem *)&PS2_COMMAND) > -#define I8042_STATUS_REG ((volatile void __iomem *)&PS2_STATUS) > -#define I8042_DATA_REG ((volatile void __iomem *)&PS2_DATA) > +#define I8042_COMMAND_REG PS2_COMMAND > +#define I8042_STATUS_REG PS2_STATUS > +#define I8042_DATA_REG PS2_DATA I wouldn't bother defining two sets of macros then. Either use PS2_COMMAND in the driver, or define I8042_COMMAND_REG in the place where you currently define PS2_COMMAND. Aside from this, it looks good. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists