linux-kernel - Re: [PATCH] jump label: introduce static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1298455885.2217.354.camel@twins>
Date:	Wed, 23 Feb 2011 11:11:25 +0100
From:	Peter Zijlstra <peterz@...radead.org>
To:	Jason Baron <jbaron@...hat.com>
Cc:	hpa@...or.com, mathieu.desnoyers@...ymtl.ca, rostedt@...dmis.org,
	mingo@...e.hu, tglx@...utronix.de, andi@...stfloor.org,
	roland@...hat.com, rth@...hat.com, masami.hiramatsu.pt@...achi.com,
	fweisbec@...il.com, avi@...hat.com, davem@...emloft.net,
	sam@...nborg.org, ddaney@...iumnetworks.com,
	michael@...erman.id.au, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] jump label: introduce static_branch() interface

On Tue, 2011-02-22 at 17:28 -0500, Jason Baron wrote:
> @@ -33,7 +28,11 @@ struct _ddebug {
>  #define _DPRINTK_FLAGS_PRINT   (1<<0)  /* printk() a message using
> the format */
>  #define _DPRINTK_FLAGS_DEFAULT 0
>         unsigned int flags:8;
> -       char enabled;
> +#ifdef HAVE_JUMP_LABEL
> +       struct jump_label_key enabled;
> +#else
> +       int enabled;
> +#endif
>  } __attribute__((aligned(8)));
>   

Also, didn't you promise Mathieu a comment explaining why dynamic debug
does funny things like this? :-) I mean we all know its because of the
cyclic header stuff involving atomic etc.. but I'm also quite sure we'll
all have forgotten about that in a few weeks time.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/