linux-kernel - [tip:x86/urgent] x86/mrst: Fix apb timer rating when lapic timer is used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tip-7b62dbec908a29f448047099bedb5c64c9cb8808@git.kernel.org>
Date:	Thu, 24 Feb 2011 07:28:06 GMT
From:	tip-bot for Jacob Pan <jacob.jun.pan@...ux.intel.com>
To:	linux-tip-commits@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, alan@...ux.intel.com, hpa@...or.com,
	mingo@...hat.com, arjan@...ux.intel.com, john.stultz@...aro.org,
	tglx@...utronix.de, jacob.jun.pan@...ux.intel.com, mingo@...e.hu
Subject: [tip:x86/urgent] x86/mrst: Fix apb timer rating when lapic timer is used

Commit-ID:  7b62dbec908a29f448047099bedb5c64c9cb8808
Gitweb:     http://git.kernel.org/tip/7b62dbec908a29f448047099bedb5c64c9cb8808
Author:     Jacob Pan <jacob.jun.pan@...ux.intel.com>
AuthorDate: Wed, 23 Feb 2011 16:07:26 -0800
Committer:  Ingo Molnar <mingo@...e.hu>
CommitDate: Thu, 24 Feb 2011 08:22:43 +0100

x86/mrst: Fix apb timer rating when lapic timer is used

Need to adjust the clockevent device rating for the structure
that will be registered with clockevent system instead of the
temporary structure.

Without this fix, APB timer rating will be higher than LAPIC
timer such that it can not be released later to be used as the
broadcast timer.

Signed-off-by: Jacob Pan <jacob.jun.pan@...ux.intel.com>
Cc: Arjan van de Ven <arjan@...ux.intel.com>
Cc: Alan Cox <alan@...ux.intel.com>
Cc: Thomas Gleixner <tglx@...utronix.de>
Cc: John Stultz <john.stultz@...aro.org>
LKML-Reference: <1298506046-439-1-git-send-email-jacob.jun.pan@...ux.intel.com>
Signed-off-by: Ingo Molnar <mingo@...e.hu>
---
 arch/x86/kernel/apb_timer.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/apb_timer.c b/arch/x86/kernel/apb_timer.c
index 51ef31a..51d4e16 100644
--- a/arch/x86/kernel/apb_timer.c
+++ b/arch/x86/kernel/apb_timer.c
@@ -284,7 +284,7 @@ static int __init apbt_clockevent_register(void)
 	memcpy(&adev->evt, &apbt_clockevent, sizeof(struct clock_event_device));
 
 	if (mrst_timer_options == MRST_TIMER_LAPIC_APBT) {
-		apbt_clockevent.rating = APBT_CLOCKEVENT_RATING - 100;
+		adev->evt.rating = APBT_CLOCKEVENT_RATING - 100;
 		global_clock_event = &adev->evt;
 		printk(KERN_DEBUG "%s clockevent registered as global\n",
 		       global_clock_event->name);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/