linux-kernel - Can't build in the virtio console driver on x86_64 when the other virtio drivers are modular

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110224112819.10f59f68@katamari>
Date:	Thu, 24 Feb 2011 11:28:19 -0500
From:	Chuck Ebbert <cebbert@...hat.com>
To:	virtualization@...ts.linux-foundation.org
Cc:	linux-kernel@...r.kernel.org, Amit Shah <amit.shah@...hat.com>
Subject: Can't build in the virtio console driver on x86_64 when the other
 virtio drivers are modular

The virtio configuration options are inconsistent. According to this,
every options that needs virtio will select it:

 # Virtio always gets selected by whoever wants it.
 config VIRTIO
        tristate

Note that it's not user-selectable, so any config file that tries to
set it will be ignored when kconfig loads those options. And yet we
have a whole set of options that depend on VIRTIO, like VIRTIO_CONSOLE
for example. This makes it impossible to have VIRTIO_PCI modular and
VIRTIO_CONSOLE built-in on x86_64, because:

1. VIRTIO_PCI selects VIRTIO and sets it to M
2. VIRTIO_CONSOLE gets forced to M because one of its dependencies is M

So either VIRTIO (and VIRTIO_RING) need to be user-selectable, or all
of the options that depend on VIRTIO need to be changed to select it
instead.

(For even more fun, LGUEST_GUEST on i386 forces VIRTIO, VIRTIO_RING and
VIRTIO_CONSOLE all to Y.)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/