linux-kernel - Re: [RFC 2/3] xhci: Fix cycle bit calculation during stall handling.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110224183555.GA2283@core.coreip.homeip.net>
Date:	Thu, 24 Feb 2011 10:35:55 -0800
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Greg KH <greg@...ah.com>
Cc:	Sarah Sharp <sarah.a.sharp@...ux.intel.com>,
	Sergei Shtylyov <sshtylyov@...sta.com>,
	Takashi Iwai <tiwai@...e.de>, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [RFC 2/3] xhci: Fix cycle bit calculation during stall handling.

On Thu, Feb 24, 2011 at 09:04:10AM -0800, Greg KH wrote:
> On Thu, Feb 24, 2011 at 07:38:55AM -0800, Sarah Sharp wrote:
> > On Thu, Feb 24, 2011 at 02:18:24PM +0300, Sergei Shtylyov wrote:
> > > Hello.
> > > 
> > > On 24-02-2011 5:31, Sarah Sharp wrote:
> > > 
> > > >+	if (ep_ring->first_seg == ep_ring->first_seg->next&&
> > > >+			state->new_deq_ptr < dev->eps[ep_index].stopped_trb)
> > > >+			state->new_cycle_state ^= 0x1;
> > > 
> > >    The last line seems overindented.
> > 
> > Hi Sergei,
> > 
> > checkpatch.pl doesn't complain about it.  It is not a good use of my
> > time to respin this patch for one stylistic change that is not a
> > violation of the Kernel community norms.
> > 
> > I really feel strongly that you are wasting the community's time by
> > commenting on style when it is only a violation of your personal style,
> > without providing any useful feedback on the code itself.
> > 
> > I feel so strongly that I'm seriously considering setting up a feedback
> > bot for you.  It would run any patch you reply to through checkpatch.pl,
> > and send you a small reminder when the patch passes, but you complained
> > about style.  I think it would allow you to have a sense of how
> > frustrating it is to receive these unnecessary stylistic comments.
> 
> I totally agree, and almost always just filter Sergei's comments away as
> the large majority of them are pointless and distract from the technical
> content being discussed.
> 

I am sorry, but in this case the 'if' body does run together with the
conditional. No need to repost the patch for this, of course, but might
be worth fixing locally before pushing into a public branch.

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/