linux-kernel - Re: [RFC 2/3] xhci: Fix cycle bit calculation during stall handling.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4D66AFDB.5010005@ru.mvista.com>
Date:	Thu, 24 Feb 2011 22:22:03 +0300
From:	Sergei Shtylyov <sshtylyov@...sta.com>
To:	Sarah Sharp <sarah.a.sharp@...ux.intel.com>
CC:	Sergei Shtylyov <sshtylyov@...sta.com>,
	Takashi Iwai <tiwai@...e.de>, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [RFC 2/3] xhci: Fix cycle bit calculation during stall handling.

Hello.

Sarah Sharp wrote:

>>> +	if (ep_ring->first_seg == ep_ring->first_seg->next&&
>>> +			state->new_deq_ptr < dev->eps[ep_index].stopped_trb)
>>> +			state->new_cycle_state ^= 0x1;

>>    The last line seems overindented.

> Hi Sergei,

> checkpatch.pl doesn't complain about it.  It is not a good use of my
> time to respin this patch for one stylistic change that is not a
> violation of the Kernel community norms.

> I really feel strongly that you are wasting the community's time by
> commenting on style when it is only a violation of your personal style,
> without providing any useful feedback on the code itself.

    Not only of my personal style, as Dmitry's comment has shown. Like him, I 
had some trouble seeing where the *if* expression ends and the branch starts, 
due to both lines starting on the same level of indentation...

> I feel so strongly that I'm seriously considering setting up a feedback
> bot for you.  It would run any patch you reply to through checkpatch.pl,
> and send you a small reminder when the patch passes, but you complained
> about style.  I think it would allow you to have a sense of how
> frustrating it is to receive these unnecessary stylistic comments.

    Well, I'll try to save you that trouble and avoid commenting on your patches 
in the future.

> Sarah Sharp

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/