linux-kernel - Re: [PATCH v4 3/5] hwmon: (pmbus) Add support for Maxim MAX16064

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1298670164.1735.108.camel@groeck-laptop>
Date:	Fri, 25 Feb 2011 13:42:44 -0800
From:	Guenter Roeck <guenter.roeck@...csson.com>
To:	Jonathan Cameron <jic23@....ac.uk>
CC:	Jean Delvare <khali@...ux-fr.org>,
	Jonathan Cameron <kernel@...23.retrosnub.co.uk>,
	Randy Dunlap <rdunlap@...otime.net>,
	Greg Schnorr <gschnorr@...co.com>,
	"lm-sensors@...sensors.org" <lm-sensors@...sensors.org>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 3/5] hwmon: (pmbus) Add support for Maxim MAX16064

Hi Jonathan,

On Fri, 2011-02-25 at 15:26 -0500, Jonathan Cameron wrote:
> Again, straight forward use of pmbus_core.  Is it actually worth having
> separate modules for each of these special cases?  Could just do the
> old big table of fixed chip info structures in a single driver...
> 
This is actually what I had originally. My reasoning to split it up was
that this makes it easier to add support for additional chips without
having to modify the core driver. Also, I can keep chip specific code
(specifically the _identify and _get_status functions) out of the core
driver.

Thanks,
Guenter


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/