linux-kernel - Re: [PATCH] Staging: keucr: Remove all type defines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110301200006.GX18043@bicker>
Date:	Tue, 1 Mar 2011 23:00:06 +0300
From:	Dan Carpenter <error27@...il.com>
To:	Roel Van Nyen <roel.vannyen@...il.com>
Cc:	gregkh@...e.de, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org, acho@...ell.com
Subject: Re: [PATCH] Staging: keucr: Remove all type defines

On Tue, Mar 01, 2011 at 08:29:50PM +0100, Roel Van Nyen wrote:
> Remove all type defines from driver and replace them with kernel built-in types.
> 
> Signed-off-by: Roel Van Nyen <roel.vannyen@...il.com>

Some of your other patches were merged so this doesn't apply to
linux-next any more.

> -typedef u8 BOOLEAN;

It might be better to use bool type or int for boolean variables.  But
that can't be done automatically, it has to be audited carefully.  I
don't feel strongly about this, I'm just throwing it out there as food
for thought.  You are using the remove-typedef program btw?

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/