linux-kernel - Re: [PATCH v9 1/1] PRUSS UIO driver support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 3 Mar 2011 19:15:55 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	Pratheesh Gangadhar <pratheesh@...com>
Cc:	linux-kernel@...r.kernel.org, hjk@...sjkoch.de, gregkh@...e.de,
	tglx@...utronix.de, sshtylyov@...sta.com, amit.chatterjee@...com,
	davinci-linux-open-source@...ux.davincidsp.com,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v9 1/1] PRUSS UIO driver support

On Thursday 03 March 2011 19:07:57 Pratheesh Gangadhar wrote:
> +struct uio_pruss_dev {
> +       struct uio_info *info;
> +       struct clk *pruss_clk;
> +       dma_addr_t sram_paddr;
> +       dma_addr_t ddr_paddr;
> +       void __iomem *prussio_vaddr;
> +       void *sram_vaddr;
> +       void *ddr_vaddr;
> +       unsigned int hostirq_start;
> +       unsigned int pintc_base;
> +};
> +
> +struct pruss_priv {
> +       struct uio_pruss_dev *pupdev;
> +};

I cannot see the point of struct pruss_priv, I think it would be better to
just merge the two data structures into one. Everything else looks
good to me now.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/