linux-kernel - Re: [PATCHv2 1/7] x86: remove superflous goal definition of tsc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTimptB1K3Kc+Hy1JbY=38pHSp0FfjA1LAKniLV2m@mail.gmail.com>
Date:	Fri, 4 Mar 2011 15:50:28 +0300
From:	Cyrill Gorcunov <gorcunov@...il.com>
To:	Henrik Kretzschmar <henne@...htwindheim.de>
Cc:	mingo@...e.hu, tglx@...utronix.de, hpa@...or.com, x86@...nel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCHv2 1/7] x86: remove superflous goal definition of tsc_sync

On Fri, Mar 4, 2011 at 3:43 PM, Cyrill Gorcunov <gorcunov@...il.com> wrote:
> On Fri, Mar 4, 2011 at 2:58 PM, Henrik Kretzschmar
> <henne@...htwindheim.de> wrote:
>> This goal definition is superflous.
>> CONFIG_X86_64_SMP depends on CONFIG_SMP
>> and tsc_sync.o is already in the definition of CONFIG_SMP.
>>
>> Signed-off-by: Henrik Kretzschmar <henne@...htwindheim.de>
>> ---
>>  arch/x86/kernel/Makefile |    1 -
>>  1 files changed, 0 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/x86/kernel/Makefile b/arch/x86/kernel/Makefile
>> index 4ad4509..6b61081 100644
>> --- a/arch/x86/kernel/Makefile
>> +++ b/arch/x86/kernel/Makefile
>> @@ -69,7 +69,6 @@ obj-$(CONFIG_APM)             += apm.o
>>  obj-$(CONFIG_SMP)              += smp.o
>>  obj-$(CONFIG_SMP)              += smpboot.o tsc_sync.o
>>  obj-$(CONFIG_SMP)              += setup_percpu.o
>> -obj-$(CONFIG_X86_64_SMP)       += tsc_sync.o
>>  obj-$(CONFIG_X86_MPPARSE)      += mpparse.o
>>  obj-y                          += apic/
>>  obj-$(CONFIG_X86_REBOOTFIXUPS) += reboot_fixups_32.o
>> --
>> 1.7.2.3
>>
>>
>
> Probably we better write it this way:
>
> - obj-$(CONFIG_SMP)              += smpboot.o tsc_sync.o
> - obj-$(CONFIG_X86_64_SMP)       += tsc_sync.o
>
> + obj-$(CONFIG_SMP)              += smpboot.o
> + obj-$(CONFIG_SMP)              += tsc_sync.o
>
> I guess this would be cleaner? Ingo?
>

Others patches in series looks good to me, feel free to add
Acked-by: Cyrill Gorcunov <gorcunov@...nvz.org>
when needed. Thanks a lot!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/