linux-kernel - Re: [PATCH x86/mm] x86-64, NUMA: Don't assume phys node 0 is always online in numa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110305075033.GB20499@htj.dyndns.org>
Date:	Sat, 5 Mar 2011 08:50:33 +0100
From:	Tejun Heo <tj@...nel.org>
To:	David Rientjes <rientjes@...gle.com>
Cc:	Yinghai Lu <yinghai@...nel.org>, Ingo Molnar <mingo@...e.hu>,
	tglx@...utronix.de, "H. Peter Anvin" <hpa@...or.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH x86/mm] x86-64, NUMA: Don't assume phys node 0 is
 always online in numa_emulation() handling

On Fri, Mar 04, 2011 at 01:33:29PM -0800, David Rientjes wrote:
> On Fri, 4 Mar 2011, Tejun Heo wrote:
> 
> > Undetermined entries in emu_nid_to_phys[] are filled with zero
> > assuming that physical node 0 is always online; however, this might
> > not be true depending on hardware configuration.  Find a physical node
> > which is actually online and use it instead.
> > 
> 
> I still don't understand why emu_nid_to_phys[] can't return NUMA_NO_NODE 
> and this needs to be done at all.  An emulated node should be mapped to a 
> physical node based on the address ranges of that emulated node, so it's 
> impossible for that to not map directly to a physical online node.  We 
> don't support memoryless emulated nodes for hotpluggable SRAT entries.

Me neither.  That was the original logic.  I just transformed the
logic into emu_nid_to_phys[].  If you think you can remove that
safely, please go ahead and submit a patch.  That said, it's not
exactly high priority thing to do.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/