linux-kernel - Undefined TASK_INTERRUPTIBLE (Was: Re: [PATCH 1/3] iwlwifi: move rx handlers code to iwl-rx.c)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 7 Mar 2011 09:12:45 +0100
From:	Stanislaw Gruszka <sgruszka@...hat.com>
To:	Daniel Halperin <dhalperi@...washington.edu>,
	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...e.hu>
Cc:	"Guy, Wey-Yi" <wey-yi.w.guy@...el.com>,
	Intel Linux Wireless <ilw@...ux.intel.com>,
	"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
	linux-kernel@...r.kernel.org
Subject: Undefined TASK_INTERRUPTIBLE (Was: Re: [PATCH 1/3] iwlwifi: move rx
 handlers code to iwl-rx.c)

On Sun, Mar 06, 2011 at 03:47:55PM -0800, Daniel Halperin wrote:
> This fixes the error for me.

Code compile on 64 bits, but fail on 32, hmm ...

> Dan
> 
> index 7dc2d39..e3ba4d5 100644
> --- a/drivers/net/wireless/iwlwifi/iwl-rx.c
> +++ b/drivers/net/wireless/iwlwifi/iwl-rx.c
> @@ -30,6 +30,7 @@
>  #include <linux/etherdevice.h>
>  #include <linux/slab.h>
>  #include <net/mac80211.h>
> +#include <linux/sched.h>
>  #include <asm/unaligned.h>
>  #include "iwl-eeprom.h"
>  #include "iwl-dev.h"

This fixes the problem, I will post signed-off patch to John in
a second.

But perhaps we need a more generic fix in wait.h for the future. Maybe
we should decouple definitions of TASK_INTERRUPTIBLE and friends from
sched.h into separate header and include that header in wait.h as well?

Stanislaw

> On Sun, Mar 6, 2011 at 1:34 PM, Guy, Wey-Yi <wey-yi.w.guy@...el.com> wrote:
> > Hi Stanislaw,
> >
> > On Fri, 2011-03-04 at 08:51 -0800, Stanislaw Gruszka wrote:
> >> Put generic rx_handlers (except iwlagn_rx_reply_compressed_ba) to
> >> iwl-rx.c . Make functions static and change prefix from iwlagn_ to
> >> iwl_ . Beautify iwl_setup_rx_handlers and do some other minor coding
> >> style changes.
> >>
> >> Signed-off-by: Stanislaw Gruszka <sgruszka@...hat.com>
> >> ---
> > this patch break the compiling
> >
> > drivers/net/wireless/iwlwifi/iwl-rx.c:778:17: error: undefined
> > identifier 'TASK_INTERRUPTIBLE'
> >  CC [M]  drivers/net/wireless/iwlwifi/iwl-rx.o
> > drivers/net/wireless/iwlwifi/iwl-rx.c: In function
> > ‘iwl_rx_card_state_notif’:
> > drivers/net/wireless/iwlwifi/iwl-rx.c:778: error: ‘TASK_INTERRUPTIBLE’
> > undeclared (first use in this function)
> > drivers/net/wireless/iwlwifi/iwl-rx.c:778: error: (Each undeclared
> > identifier is reported only once
> > drivers/net/wireless/iwlwifi/iwl-rx.c:778: error: for each function it
> > appears in.)
> > make[1]: *** [drivers/net/wireless/iwlwifi/iwl-rx.o] Error 1
> > make: *** [_module_drivers/net/wireless/iwlwifi] Error 2
> >
> >
> > Thanks
> > Wey
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> > the body of a message to majordomo@...r.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> >
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/