linux-kernel - Re: [PATCH v3] misc: adds support the FSA9480 USB Switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110308135909.GA7519@kroah.com>
Date:	Tue, 8 Mar 2011 05:59:09 -0800
From:	Greg KH <greg@...ah.com>
To:	Minkyu Kang <mk7.kang@...sung.com>
Cc:	linux-kernel@...r.kernel.org, linux-i2c@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	kyungmin.park@...sung.com, Ben Dooks <ben-i2c@...ff.org>
Subject: Re: [PATCH v3] misc: adds support the FSA9480 USB Switch

On Tue, Mar 08, 2011 at 03:56:56PM +0900, Minkyu Kang wrote:
> --- /dev/null
> +++ b/include/linux/fsa9480.h

Why do you need a .h file for this driver?

If it's just for platform data, please put it in
include/linux/platform_data/ instead.

If it's not, then please just move it to your driver's .c file.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/